[JENKINS-73335] add support for PEM encoded certificate (and key) #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtnord
commented
Jun 24, 2024
6 tasks
…atted Provides an alternative method for entering Certificate credentials, required when running in FIPS as we can not use PKCS12
As PEMs are not binary files but tet encoding it makes more sense to have users enter them. Additionally feedback is that user normally manage the certificate chain and keys separately
Now that formvalidation has been manually tested swap back to SecretTextArea The formValidation won't work pending JENKINS-73404 (and to some extent JENKINS-65616) but once they are fixed will magically start working
jtnord
commented
Jul 5, 2024
| @@ -55,6 +55,11 @@ | |||
| uploadedCertFileInput.onchange = fileOnChange.bind(uploadedCertFileInput); | |||
| } | |||
| function fileOnChange() { | |||
| // only trigger validation if the PKCS12 upload is selected | |||
There was a problem hiding this comment.
as there is more than one option, only trigger this validation if this descriptor is chosen.
src/main/java/com/cloudbees/plugins/credentials/impl/CertificateCredentialsImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cloudbees/plugins/credentials/impl/CertificateCredentialsImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cloudbees/plugins/credentials/impl/CertificateCredentialsImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cloudbees/plugins/credentials/impl/CertificateCredentialsImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cloudbees/plugins/credentials/impl/CertificateCredentialsImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cloudbees/plugins/credentials/impl/CertificateCredentialsImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cloudbees/plugins/credentials/impl/CertificateCredentialsImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cloudbees/plugins/credentials/impl/CertificateCredentialsImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cloudbees/plugins/credentials/impl/CertificateCredentialsImpl.java
Outdated
Show resolved
Hide resolved
jtnord
added a commit
to jtnord/bom
that referenced
this pull request
Jul 8, 2024
This was referenced Jul 8, 2024
jtnord
added a commit
to jtnord/pipeline-model-definition-plugin
that referenced
this pull request
Jul 8, 2024
amends jenkinsci#723 that was working as the KeyStore was not validated. However jenkinsci/credentials-plugin#543 now validates the keystore and hence this test started failing as the password did not match
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jenkins.io/browse/JENKINS-73335
Testing done
Tested in a FIPS configured environment (e2e running Jenkins.war) and with
mvn hpi:runin a regular dev environment.tested both valid and invalid keys / password combinations and valid but not FIPS compliant keys.
FormValidation was working except https://issues.jenkins.io/browse/JENKINS-65616 and when regular textAreas where used for the secret (before switching to
SecretTextAreafor which https://issues.jenkins.io/browse/JENKINS-73404 has been raised)introduced a new test to cover a happy case path usign the UI to enter a password protected key and cert.
Submitter checklist