[JENKINS-57993] Verify no warnings are printed for a basic build #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed for a basic build using podTemplate.
jglick
commented
Jun 12, 2019
| @@ -103,10 +107,6 @@ public void runInPod() throws Exception { | |||
| pods.getItems(), hasSize(1)); | |||
| SemaphoreStep.success("pod/1", null); | |||
|
|
|||
| for (String msg : logs.getMessages()) { | |||
There was a problem hiding this comment.
Not very useful; left over from 23a0fce.
jglick
commented
Jun 12, 2019
|
ci.jenkins.io test failure is that addressed in #496. |
…stractAsyncNodeMonitorDescriptor errors would now be printed.
|
assertNotNull(timeoutTemplate);which I cannot reproduce locally. I suspect it is a race condition in the test. |
|
Getting a failure from |
jglick
commented
Sep 27, 2019
| @@ -205,6 +205,12 @@ | |||
| </exclusion> | |||
| </exclusions> | |||
| </dependency> | |||
| <dependency> <!-- TODO for #sshagent pending https://github.com/jenkinsci/ssh-credentials-plugin/pull/47 --> | |||
There was a problem hiding this comment.
Vlatombe
approved these changes
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream of jenkinsci/jenkins#4066.