Improve logging for Computer.getLogDir failures #4226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvz
approved these changes
Sep 25, 2019
res0nance
approved these changes
Sep 25, 2019
timja
approved these changes
Sep 26, 2019
oleg-nenashev
added
the
rfe
oleg-nenashev
changed the title
oleg-nenashev
approved these changes
Sep 26, 2019
oleg-nenashev
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw a flake of jenkinsci/kubernetes-plugin#503 with a one-line error
Now the null
nodeNamelooks wrong, but even still it should have been able to create a directory of that name. TheFile.mkdirscall does not tell us why it failed. Nor does the log message indicate what code was callinggetLogDir, which may be relevant.Proposed changelog entries
Computer.getLogDir.