Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh plugin for March 2023 #1265

Merged
merged 4 commits into from
Mar 17, 2023
Merged

Refresh plugin for March 2023 #1265

merged 4 commits into from
Mar 17, 2023

Conversation

basil
Copy link
Member

@basil basil commented Mar 17, 2023

The use of Gradle for Jenkins plugins is deprecated and is a liability, so this PR switches this plugin away from Gradle in favor of Maven and Webpack. The latter required upgrading Marionette and Backbone to the latest version.

This is a massive PR, and I do not expect anyone else to understand it or review it. I plan to adopt this plugin to merge and release this PR.

I have done significant interactive testing in the Jenkins UI of both plugin functionality and the API viewer. I am still testing the maven-scm-publish-plugin portions of this PR, but I figured I would get the ball rolling by running some CI builds.

Closes #1252

@basil
Copy link
Member Author

basil commented Mar 17, 2023

Used my admin powers to replay the build with the Jenkinsfile changes here: https://ci.jenkins.io/job/Plugins/job/job-dsl-plugin/job/PR-1265/2/

@basil
Copy link
Member Author

basil commented Mar 17, 2023

@strangelookingnerd
Copy link
Contributor

@basil Thank you so much for this!

@basil basil added the internal label Mar 17, 2023
@basil basil marked this pull request as ready for review March 17, 2023 14:32
@basil basil merged commit 5a83057 into jenkinsci:master Mar 17, 2023
@basil basil deleted the build branch March 17, 2023 14:32
@jamietanna
Copy link
Contributor

Massive thank you for this 👏🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants