Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JEP-226] Improve migration section #292

Merged
merged 4 commits into from
Jul 17, 2020

Conversation

stellargo
Copy link
Contributor

@stellargo stellargo commented Jun 17, 2020

Improves the migration section of JEP 226. See jenkinsci/jenkins#4825

@stellargo stellargo requested a review from a team as a code owner June 17, 2020 19:31
jep/226/README.adoc Outdated Show resolved Hide resolved
@stellargo
Copy link
Contributor Author

@oleg-nenashev @afalko @mikecirioli following our last meeting, would appreciate your reviews here.

@stellargo stellargo requested a review from afalko June 19, 2020 18:29
@oleg-nenashev
Copy link
Member

oops, I forgot to merge it

@oleg-nenashev
Copy link
Member

@stellargo is it still actual after the initial implementation?

@stellargo
Copy link
Contributor Author

@oleg-nenashev the implementation was the same. However I improved the language and made it merge ready :)

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@oleg-nenashev oleg-nenashev merged commit 8d31aee into jenkinsci:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants