[JENKINS-62757] Introduce fingerprint migration in External Storage API #4825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is WIP currently. |
res0nance
added
the
work-in-progress
stellargo
changed the title
|
@oleg-nenashev @afalko @mikecirioli This is the migration PR. Work is done but suggest putting it on hold till #4834 is merged. |
afalko
reviewed
Jul 13, 2020
test/src/test/java/jenkins/fingerprints/FingerprintStorageTest.java
Outdated
Show resolved
Hide resolved
afalko
reviewed
Jul 13, 2020
afalko
suggested changes
Jul 13, 2020
|
@afalko @oleg-nenashev @mikecirioli request for review :) |
oleg-nenashev
added
rfe
timja
approved these changes
Jul 23, 2020
oleg-nenashev
requested changes
Jul 23, 2020
oleg-nenashev
approved these changes
Jul 27, 2020
There was a problem hiding this comment.
Should be good to go, thanks @stellargo !
We may merge it in 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process
oleg-nenashev
added
the
ready-for-merge
oleg-nenashev
approved these changes
Jul 30, 2020
There was a problem hiding this comment.
👍 for catching the bug @stellargo . Resetting the merge timer
We may merge it in 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-62757.
See JEP-226.
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entriessection only if there are breaking changes or other changes which may require extra steps from users during the upgradeDesired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge:Proposed changelog entriesare correctupgrade-guide-neededlabel is set and there is aProposed upgrade guidelinessection in the PR title. (example)lts-candidateto be considered (see query).