Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for JEP-200 #35

Merged
merged 1 commit into from
Nov 5, 2018
Merged

Fixes for JEP-200 #35

merged 1 commit into from
Nov 5, 2018

Conversation

CSLTech
Copy link
Contributor

@CSLTech CSLTech commented Mar 1, 2018

Simple fixes for JEP-200 compatibility.

@oleg-nenashev
Copy link
Member

Added the issue to https://wiki.jenkins.io/display/JENKINS/Plugins+affected+by+fix+for+JEP-200. If you see JEP-200 regressions, please report them according to these guidelines so that JEP-200 maintainers get notification about the defect. We do not monitor GitHub pull requests.

@oleg-nenashev
Copy link
Member

@lessonz are you the current plugin's maintainer? If yes, a review/release would be appreciated. This issue complicates usage of the plugin with Jenkins 2.102+

@lessonz
Copy link
Member

lessonz commented Apr 2, 2018

@CSLTech is in the process of getting perms for maintaining this plugin.

@oleg-nenashev
Copy link
Member

Permissions granted. Thanks again @lessonz

@@ -38,7 +38,7 @@
private FitnesseResults parent;
private List<FitnesseResults> details = new ArrayList<FitnesseResults>();
private transient Run<?,?> owner;
private TaskListener listener;
private transient TaskListener listener;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally need to either restore in readResolve, or stop making it an instance field altogether (use a local variable), or access only via a getter which sets it on demand.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. It would be also reasonable to rename the field at least so that it does not cause deserialization warnings for obsolete data

@oleg-nenashev
Copy link
Member

@CSLTech Please let us know if you need any help with the release. You should have all required permissions now

@oleg-nenashev
Copy link
Member

@lessonz @CSLTech hi, gentle ping. Let us know if you need any help with the release. JEP-200 maintenance period expires on May 01, and it would be great to minimize the number of leftovers

@CSLTech
Copy link
Contributor Author

CSLTech commented Apr 24, 2018

@oleg-nenashev Things have been hectic around here with a rush to deploy certain features. I have just landed on my feet. I will be publishing the build this week.

@oleg-nenashev
Copy link
Member

ack, thanks for the update!

@oleg-nenashev
Copy link
Member

@CSLTech It has not been published yet AFAICT

@daldinger daldinger mentioned this pull request Jun 11, 2018
@oleg-nenashev
Copy link
Member

@CSLTech gentle ping

@jaruzafa jaruzafa merged commit 1d8ebb3 into jenkinsci:master Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants