-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for JEP-200 #35
Conversation
Added the issue to https://wiki.jenkins.io/display/JENKINS/Plugins+affected+by+fix+for+JEP-200. If you see JEP-200 regressions, please report them according to these guidelines so that JEP-200 maintainers get notification about the defect. We do not monitor GitHub pull requests. |
@lessonz are you the current plugin's maintainer? If yes, a review/release would be appreciated. This issue complicates usage of the plugin with Jenkins 2.102+ |
@CSLTech is in the process of getting perms for maintaining this plugin. |
Permissions granted. Thanks again @lessonz |
@@ -38,7 +38,7 @@ | |||
private FitnesseResults parent; | |||
private List<FitnesseResults> details = new ArrayList<FitnesseResults>(); | |||
private transient Run<?,?> owner; | |||
private TaskListener listener; | |||
private transient TaskListener listener; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally need to either restore in readResolve
, or stop making it an instance field altogether (use a local variable), or access only via a getter which sets it on demand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. It would be also reasonable to rename the field at least so that it does not cause deserialization warnings for obsolete data
@CSLTech Please let us know if you need any help with the release. You should have all required permissions now |
@oleg-nenashev Things have been hectic around here with a rush to deploy certain features. I have just landed on my feet. I will be publishing the build this week. |
ack, thanks for the update! |
@CSLTech It has not been published yet AFAICT |
@CSLTech gentle ping |
Simple fixes for JEP-200 compatibility.