Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin-fitnesse.yml #653

Merged

Conversation

CSLTech
Copy link
Contributor

@CSLTech CSLTech commented Mar 29, 2018

Description

Taking over for maintenance of fitnesse plugin. Plugin can be found at: https://github.com/jenkinsci/fitnesse-plugin
@lessonz approved change at https://groups.google.com/forum/#!msg/jenkinsci-dev/II-ishc_xfU/xq2rrChDAAAJ;context-place=forum/jenkinsci-dev
Refered by issue: https://issues.jenkins-ci.org/browse/HOSTING-532

Submitter checklist for changing permissions

Always

  • Add link to plugin/component Git repository in description above

For a newly hosted plugin only

  • Add link to resolved HOSTING issue in description above

For a new permissions file only

When adding new uploaders (this includes newly created permissions files)

@daniel-beck
Copy link
Contributor

Ideally @lessonz would also confirm this here, just to be sure.

Do you still need commit access to the GitHub repo as well?

@daniel-beck daniel-beck added needs response authorized unless rejected Authorized by the hosting team, but may be rejected by plugin maintainers later on labels Mar 29, 2018
@CSLTech
Copy link
Contributor Author

CSLTech commented Mar 29, 2018

I will indeed need access to the GitHub repo as well.

@lessonz
Copy link

lessonz commented Mar 30, 2018 via email

@daniel-beck
Copy link
Contributor

@lessonz Thanks! That part wasn't directed at you, sorry about that. Would still appreciate explicit overall approval of this addition to the plugin releasers / owners though.

@lessonz
Copy link

lessonz commented Apr 2, 2018

Okay, if the approval request is aimed at me, I approve.

@oleg-nenashev
Copy link
Contributor

jenkinsci/fitnesse-plugin#35 is in the scope, I'd guess.
Merging the PR since we have an explicit approval now.

Rhanks @lessonz !

@oleg-nenashev oleg-nenashev added authorization OK and removed authorized unless rejected Authorized by the hosting team, but may be rejected by plugin maintainers later on needs response labels Apr 2, 2018
@oleg-nenashev oleg-nenashev merged commit eb3cfe4 into jenkins-infra:master Apr 2, 2018
@CSLTech
Copy link
Contributor Author

CSLTech commented Apr 3, 2018

@daniel-beck The only thing missing seems to be the GitHub repo access.

Thanks

@daniel-beck
Copy link
Contributor

@CSLTech Done, you should have been added to the repo, or gotten an invitation to the jenkinsci GitHub org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants