Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated and unused Upload class #541

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

jtnord
Copy link
Member

@jtnord jtnord commented Jun 21, 2024

Remove the Upload class

Code was deprecated > 3 years ago in #208 and is unused.

usage-in-plugins showed no usage f this in either Jenkinsci or cloudbees' plugins.

Testing done

mvn hpi:run
uploaded the test cert provided with the repo.
created the following pipeline:

node {
  withCredentials([certificate(aliasVariable: 'ALIAS', credentialsId: 'ffad04d8-48f8-4f34-8726-82fb1a746fd3', keystoreVariable: 'KS', passwordVariable: 'PW')]) {
    bat 'keytool -list -v -keystore %KS% -storepass %PW%'
  }
}

checked the pipeline ran and output was expected.

updated the description of the credential and saved.
ran the job again and validated the output is still expected

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jtnord jtnord added the removed label Jun 21, 2024
@jtnord jtnord changed the title remove unused code remove deprecated and unused Upload class Jun 21, 2024
@jtnord jtnord requested a review from a team June 21, 2024 13:31
@jtnord jtnord merged commit 75303a2 into jenkinsci:master Jul 1, 2024
14 checks passed
@jtnord jtnord deleted the remove-upload branch July 1, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants