Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OrganizationFolderTest.verifyBranchPropertiesAppliedOnNewProjects in PCT #222

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

jglick
Copy link
Member

@jglick jglick commented Oct 16, 2020

Fixes the error seen in jenkinsci/bom#308 by applying the idiom from #199 to #160.

Copy link
Contributor

@chriskilding chriskilding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dwnusbaum dwnusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build failed in the deploy stage due to an infra issue:

aci-maven-3bnz5 was marked offline: Connection was broken: java.util.concurrent.TimeoutException: Ping started at 1602861327344 hasn't completed by 1602861567345
15:19:27  	at hudson.remoting.PingThread.ping(PingThread.java:134)
15:19:27  	at hudson.remoting.PingThread.run(PingThread.java:90)

Since the tests passed on all branches, I'm going to merge it anyway.

@dwnusbaum dwnusbaum merged commit 1309da6 into jenkinsci:master Oct 16, 2020
@jglick jglick deleted the pct branch October 19, 2020 12:58
@jglick
Copy link
Member Author

jglick commented Oct 21, 2020

Can this be released please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants