Drop usage of jth.jenkins-war.path #340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fails in Seems that a side effect of turning off this property is that we are getting detached plugins rather than the BOM versions in some cases—not what we want. |
|
Withdrawing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the errors in #338, I think. Probably also fixes the error in #308 by avoiding the need for jenkinsci/branch-api-plugin#222, and probably the error in #301 avoiding the need for jenkinsci/plugin-compat-tester#256.
Generally makes life easier, at the cost of weakening the test runs: we are no longer loading all the plugins in the BOM when running functional tests, only the ones mentioned in the test classpath for this particular plugin. Normally those other plugins would be irrelevant, but if they contribute
@Extensions which break functionality of more basic plugins, we will no longer catch that.