Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix app crash when refreshing episode list view #1845

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

cewert
Copy link
Member

@cewert cewert commented Jul 20, 2024

Missed this one when I was doing #1837

Ensure season meta data is valid before using to prevent app crash. This comes from the roku crash log.

Crashlog:


startingpoint    <uninitialized> 
popupnode        roSGNode:SceneManager refcnt=1 
inputeventvideo  <uninitialized> 
posttask         <uninitialized> 
tmpglobaldevice  <uninitialized> 
event            roAssociativeArray refcnt=1 count:2 
retryvideo       <uninitialized> 
video            <uninitialized> 
info             <uninitialized> 
trackselected    <uninitialized> 
panel            <uninitialized> 
button           <uninitialized> 
movie            <uninitialized> 
trailerdata      <uninitialized> 
buttons          <uninitialized> 
btn              <uninitialized> 
results          <uninitialized> 
options          <uninitialized> 
query            <uninitialized> 
viewhandled      <uninitialized> 
screencontent    <uninitialized> 
selectedindex    <uninitialized> 
albums           <uninitialized> 
series           roSGNode:TVShowDetails refcnt=1 
ptr              roArray refcnt=1 count:2 
node             roSGNode:TVSeasonData refcnt=1 
photoplayer      <uninitialized> 
photoalbumdata   <uninitialized> 
showplaybackoptiondialog <uninitialized> 
audio_stream_idx Integer val:0 (&h0) 
selecteditemtype roString refcnt=1 val:"Episode" 
selecteditem     roInvalid refcnt=1 
moviemetadata    <uninitialized> 
seasonmetadata   Invali$1 i                Integer val:27 (&h1B) 
currentscene     roSGNode:TVEpisodes refcnt=1 
currentepisode   roAssociativeArray refcnt=1 count:29 
elapsed          <uninitialized> 
itemtype         <uninitialized> 
reportingnodetype <uninitialized> 
itemnode         <uninitialized> 
reportingnode    <uninitialized> 
timespan         <uninitialized> 
msg              roSGNodeEvent refcnt=1 
deeplinkvideo    <uninitialized> 
device           roDeviceInfo refcnt=1 
input            roInput refcnt=1 
dialog           <uninitialized> 
userslastrunversion roString refcnt=1 val:"2.0.8" 
filename         <uninitialized> 
re               <uninitialized> 
configencoding   roAssociativeArray refcnt=1 count:33 
group            roSGNode:TVEpisodes refcnt=1 
scenemanager     roSGNode:SceneManager refcnt=1 
playstatetask    roSGNode:PlaystateTask refcnt=1 
m                roAssociativeArray refcnt=2 count:6 
global           Interface:ifGloba$1 args             roAssociativeArray refcnt=2 count:4 
Local Variables: 
   file/line: pkg:/source/Main.brs(218) 
#0  Function main(args As Dynamic) As Voi$1 Backtrace: 
'Dot' Operator attempted with invalid BrightScript Component or interface reference. (runtime error &hec) in pkg:/source/Main.brs(218)

which points to this line after running build-prod on 2.0.8:

currentScene.seasonData = seasonMetaData.json

Issues

Introduced in #1749
Ref #1164

@cewert cewert added the bug-fix This fixes a bug. label Jul 20, 2024
@cewert cewert requested a review from a team as a code owner July 20, 2024 19:51
@cewert cewert merged commit b580bd4 into jellyfin:2.1.z Jul 21, 2024
13 checks passed
@cewert cewert deleted the fix-season-details-crash branch July 21, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This fixes a bug.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants