Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix app crashes when refreshing episode list view #1837

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

cewert
Copy link
Member

@cewert cewert commented Jul 18, 2024

Ensure data is valid before using to prevent app crash. This comes from the roku crash log and fixes numbers 2 and 3 on this list:

roku-208-crashlog

Crashlog:

'Dot' Operator attempted with invalid BrightScript Component or interface reference. (runtime error &hec) in pkg:/source/Main.brs(210) 

'Dot' Operator attempted with invalid BrightScript Component or interface reference. (runtime error &hec) in pkg:/source/Main.brs(211) 

210 points to this line after running build-prod on 2.0.8:

for i = 0 to currentScene.objects.Items.count() - 1

211 points to this line after running build-prod on 2.0.8:

if LCase(currentScene.objects.Items[i].id) = LCase(currentEpisode.id)

Issues

Introduced in #1749
Ref #1164

@cewert cewert added the bug-fix This fixes a bug. label Jul 18, 2024
@cewert cewert requested a review from a team as a code owner July 18, 2024 15:56
@cewert cewert merged commit d329a45 into jellyfin:2.1.z Jul 18, 2024
13 checks passed
@cewert cewert deleted the fix-episode-list-crash branch July 18, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This fixes a bug.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants