Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove overhang logo and user when viewing media #1514

Merged
merged 8 commits into from
Feb 8, 2024
Merged

Remove overhang logo and user when viewing media #1514

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b2b67ae
hide overhang logo and user when viewing media
cewert Nov 18, 2023
5abe8d2
Updating images
neilsb Nov 20, 2023
f28268a
Fixing colour of Dev logo
neilsb Nov 21, 2023
b41e08f
remove left seperator from overhang
cewert Dec 6, 2023
7b37ca1
update function definitions
cewert Jan 9, 2024
95b0158
fix logoPoster dimensions
cewert Jan 9, 2024
1a875a0
specify width for overlayLogo
cewert Jan 9, 2024
d5790e1
refactor to remove else clause
cewert Feb 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions components/config/SetServerScreen.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,7 @@ sub clearErrorMessage()
m.top.errorMessage = ""
end sub

' JFScreen hook.
' Used to show logo, update the focus, the state of the data, and tells the server about the device profile.
' JFScreen hook called when the screen is displayed by the screen manager
sub OnScreenShown()
scene = m.top.getScene()
overhang = scene.findNode("overhang")
Expand Down
6 changes: 2 additions & 4 deletions components/home/Home.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@ sub loadLibraries()
m.fadeInFocusBitmap.control = "start"
end sub

' JFScreen hook.
' Used to show logo, update the focus, the state of the data, and tells the server about the device profile.
' JFScreen hook called when the screen is displayed by the screen manager
sub OnScreenShown()
scene = m.top.getScene()
overhang = scene.findNode("overhang")
Expand Down Expand Up @@ -61,8 +60,7 @@ sub OnScreenShown()
end if
end sub

' JFScreen hook.
' Remove the Jellyfin logo and left seperator from the overhang
' JFScreen hook called when the screen is hidden by the screen manager
sub OnScreenHidden()
cewert marked this conversation as resolved.
Show resolved Hide resolved
scene = m.top.getScene()
overhang = scene.findNode("overhang")
Expand Down
7 changes: 6 additions & 1 deletion components/home/HomeRows.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,12 @@ sub processUserSections()
' Add home sections in order based on user settings
loadedSections = 0
for i = 0 to 6
sectionName = LCase(m.global.session.user.settings["homesection" + i.toStr()])
sectionName = m.global.session.user.settings["homesection" + i.toStr()]
if isValid(sectionName)
sectionName = LCase(sectionName)
else
exit for
end if
cewert marked this conversation as resolved.
Show resolved Hide resolved
sectionLoaded = false
if sectionName <> "none"
sectionLoaded = addHomeSection(sectionName)
Expand Down
3 changes: 1 addition & 2 deletions components/login/UserSelect.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ sub redraw()
m.top.findNode("UserRow").translation = [leftBorder, topBorder]
end sub

' JFScreen hook.
' Used to show logo, update the focus, the state of the data, and tells the server about the device profile.
' JFScreen hook called when the screen is displayed by the screen manager
sub OnScreenShown()
cewert marked this conversation as resolved.
Show resolved Hide resolved
scene = m.top.getScene()
overhang = scene.findNode("overhang")
Expand Down