Remove overhang logo and user when viewing media #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cewert
added
the
general-improvement
|
It looks like the image quality went down a bit when I cropped these in paint 😢 We should recreate the images from the SVG sources. |
|
this is also more in line with web, which is nice. |
cewert
force-pushed
the
only-show-logo-home
branch
from
a33741e
to
b41e08f
Compare
|
This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity. |
1hitsong
suggested changes
Jan 9, 2024
1hitsong
suggested changes
Jan 13, 2024
1hitsong
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why remove the logo?
Branding is good but too much branding is bad. At the very minimum, the user will still see the logo on the home screen of the app as well as the server and user select screens. This just removes the logo from screens that display media (the home screen shows media too but is more of a dashboard) to allow the focus to be on the media itself. The user knows what app they are using at this point.
Why remove the user?
As mentioned above, the home screen is basically the dashboard for the app and this is the one screen where the currently logged in user is shown. If the user ever isn't sure who is the logged in user, then can navigate to the home screen. This also allows more focus to be on the media itself while viewing it.
Before:
After:
Changes