-
Notifications
You must be signed in to change notification settings - Fork 191
Conversation
Signed-off-by: Jan Supol <jan.supol@oracle.com>
Review needed from GlassFish team members |
Please sign Oracle Contributor Agreement(OCA) to contribute in GlassFish project if you have not done that already. |
@glassfishrobot run ci tests please |
Starting CI tests run |
One or more CI tests failed |
4 tests failed. The later 2 have: java.lang.ClassNotFoundException: org.apache.jasper.runtime.JspRuntimeLibrary$PrivilegedIntrospectHelper not found by org.glassfish.web.javax.servlet.jsp [11] |
8 failures. The same as for Tyrus #22582. |
These failures are most likely due to some existing issue with CI pipeline. If changes are final, then we can go ahead and merge the PR. Can you please confirm? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Yes, the changes are final. |
I have merged the changes. These changes would also be required in eclipse-ee4j/glassfish. Can you please raise the PR for both master and EE4J_8 branch having these changes. Thanks!! |
@vinayvishal For Eclipse GF, we would need to put new/Eclipse versions of the Jersey (2.28), Tyrus (1.15), JSON-P (1.1.3) there |
Are these Eclipse versions already released? If not, then I believe we need to have these integrated in Eclipse Glassfish first, once Eclipse versions are available, Eclipse Glassfish will then be updated again with those versions. |
ok, will submit PRs |
Signed-off-by: Jan Supol jan.supol@oracle.com