Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Update Jersey Version #22588

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Update Jersey Version #22588

merged 1 commit into from
Oct 3, 2018

Conversation

jansupol
Copy link
Contributor

@jansupol jansupol commented Oct 2, 2018

Signed-off-by: Jan Supol jan.supol@oracle.com

Signed-off-by: Jan Supol <jan.supol@oracle.com>
@glassfishrobot
Copy link
Contributor

Review needed from GlassFish team members

@glassfishrobot
Copy link
Contributor

Please sign Oracle Contributor Agreement(OCA) to contribute in GlassFish project if you have not done that already.

@lukasj
Copy link
Member

lukasj commented Oct 2, 2018

@glassfishrobot run ci tests please

@glassfishrobot
Copy link
Contributor

Starting CI tests run

@glassfishrobot
Copy link
Contributor

One or more CI tests failed

@jansupol
Copy link
Contributor Author

jansupol commented Oct 2, 2018

4 tests failed.
The first 2 do not use jersey:
jsf-with-bundled-one-dot-one-jar-files
virtual-server-with-custom-error-report-valve

The later 2 have: java.lang.ClassNotFoundException: org.apache.jasper.runtime.JspRuntimeLibrary$PrivilegedIntrospectHelper not found by org.glassfish.web.javax.servlet.jsp [11]

jsf_hello_world

@jansupol jansupol mentioned this pull request Oct 2, 2018
@jansupol
Copy link
Contributor Author

jansupol commented Oct 2, 2018

8 failures. The same as for Tyrus #22582.

@jansupol jansupol mentioned this pull request Oct 2, 2018
@vinayvishal
Copy link
Contributor

These failures are most likely due to some existing issue with CI pipeline. If changes are final, then we can go ahead and merge the PR. Can you please confirm?

@vinayvishal vinayvishal self-requested a review October 3, 2018 07:54
Copy link
Contributor

@vinayvishal vinayvishal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jansupol
Copy link
Contributor Author

jansupol commented Oct 3, 2018

Yes, the changes are final.

@vinayvishal vinayvishal merged commit 5fc2a4c into javaee:master Oct 3, 2018
@vinayvishal
Copy link
Contributor

Yes, the changes are final.

I have merged the changes. These changes would also be required in eclipse-ee4j/glassfish. Can you please raise the PR for both master and EE4J_8 branch having these changes. Thanks!!

@jansupol
Copy link
Contributor Author

jansupol commented Oct 3, 2018

@vinayvishal For Eclipse GF, we would need to put new/Eclipse versions of the Jersey (2.28), Tyrus (1.15), JSON-P (1.1.3) there

@vinayvishal
Copy link
Contributor

Are these Eclipse versions already released? If not, then I believe we need to have these integrated in Eclipse Glassfish first, once Eclipse versions are available, Eclipse Glassfish will then be updated again with those versions.

@jansupol
Copy link
Contributor Author

jansupol commented Oct 3, 2018

ok, will submit PRs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants