Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Tyrus updated to 1.14 #22582

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Tyrus updated to 1.14 #22582

merged 1 commit into from
Oct 3, 2018

Conversation

bravehorsie
Copy link
Member

Signed-off-by: Roman Grigoriadi roman.grigoriadi@oracle.com

Signed-off-by: Roman Grigoriadi <roman.grigoriadi@oracle.com>
@glassfishrobot
Copy link
Contributor

Review needed from GlassFish team members

@glassfishrobot
Copy link
Contributor

Please sign Oracle Contributor Agreement(OCA) to contribute in GlassFish project if you have not done that already.

@bravehorsie
Copy link
Member Author

@glassfishrobot run ci tests please

@glassfishrobot
Copy link
Contributor

Starting CI tests run

@glassfishrobot
Copy link
Contributor

One or more CI tests failed

@lukasj
Copy link
Member

lukasj commented Oct 2, 2018

@glassfishrobot run ci tests please

@glassfishrobot
Copy link
Contributor

Starting CI tests run

@glassfishrobot
Copy link
Contributor

One or more CI tests failed

@jansupol
Copy link
Contributor

jansupol commented Oct 2, 2018

8 failures. The same as for Jersey #22588

This was referenced Oct 2, 2018
@vinayvishal
Copy link
Contributor

These failures are most likely due to some existing issue with CI pipeline. If changes are final, then we can go ahead and merge the PR. Can you please confirm?

@vinayvishal vinayvishal self-requested a review October 3, 2018 07:43
Copy link
Contributor

@vinayvishal vinayvishal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jansupol
Copy link
Contributor

jansupol commented Oct 3, 2018

Yes, the changes are final.

@vinayvishal vinayvishal merged commit 4c78242 into javaee:master Oct 3, 2018
@vinayvishal
Copy link
Contributor

Yes, the changes are final.

I have merged the changes. These changes would also be required in eclipse-ee4j/glassfish. Can you please raise the PR for both master and EE4J_8 branch having these changes. Thanks!!

@pzygielo
Copy link

pzygielo commented Oct 3, 2018

What is the reasoning for this madness (i.e. accepting plenty of changes for this so called paused project and then propagating them to the eclipse' one)?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants