-
Notifications
You must be signed in to change notification settings - Fork 191
Conversation
Signed-off-by: Roman Grigoriadi <roman.grigoriadi@oracle.com>
Review needed from GlassFish team members |
Please sign Oracle Contributor Agreement(OCA) to contribute in GlassFish project if you have not done that already. |
@glassfishrobot run ci tests please |
Starting CI tests run |
One or more CI tests failed |
@glassfishrobot run ci tests please |
Starting CI tests run |
One or more CI tests failed |
8 failures. The same as for Jersey #22588 |
These failures are most likely due to some existing issue with CI pipeline. If changes are final, then we can go ahead and merge the PR. Can you please confirm? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Yes, the changes are final. |
I have merged the changes. These changes would also be required in eclipse-ee4j/glassfish. Can you please raise the PR for both master and EE4J_8 branch having these changes. Thanks!! |
What is the reasoning for this madness (i.e. accepting plenty of changes for this so called paused project and then propagating them to the eclipse' one)? |
Signed-off-by: Roman Grigoriadi roman.grigoriadi@oracle.com