Fix endless trace HTTP requests #136

tiffon · 2017-12-16T03:00:45Z

Fix #128 - problem of endless HTTP requests when there are caps in the trace ID specified in the URL or when the trace data returned has "" as the traceID.

I'm not able to reproduce the second scenario, but I made an effort to address it—an error will be shown instead of issuing endless HTTP requests.

Signed-off-by: Joe Farro <joef@uber.com>

codecov · 2017-12-16T03:00:48Z

Codecov Report

Merging #136 into master will increase coverage by 0.04%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
+ Coverage   92.28%   92.32%   +0.04%     
==========================================
  Files          81       81              
  Lines        1789     1799      +10     
  Branches      345      348       +3     
==========================================
+ Hits         1651     1661      +10     
  Misses        126      126              
  Partials       12       12

Impacted Files	Coverage Δ
src/components/App/TraceIDSearchInput.js	`14.28% <0%> (ø)`	⬆️
src/reducers/trace.js	`78.57% <66.66%> (-4.77%)`	⬇️
src/components/TracePage/index.js	`98.86% <75%> (-1.14%)`	⬇️
src/model/transform-trace-data.js	`79.48% <75%> (-0.52%)`	⬇️
...neViewer/TimelineHeaderRow/TimelineViewingLayer.js	`92.59% <0%> (+5.55%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffbbcea...6c6a82c. Read the comment docs.

yurishkuro · 2017-12-16T03:03:59Z

src/model/transform-trace-data.js

-export default function transfromTraceData(data: TraceData & { spans: SpanWithProcess[] }): Trace {
+export default function transfromTraceData(data: TraceData & { spans: SpanWithProcess[] }): ?Trace {
+  const traceID = data.traceID.toLowerCase();
+  if (!traceID) {


this looks like a check for traceID==null, shouldn't it be before L29?

Checking for empty string, but to be cautious will adjust.

Signed-off-by: Joe Farro <joef@uber.com>

…less-trace-http-reqs Fix endless trace HTTP requests Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>

Fix endless trace HTTP requests

2b7d803

Signed-off-by: Joe Farro <joef@uber.com>

tiffon requested review from saminzadeh, black-adder, vprithvi and yurishkuro December 16, 2017 03:00

yurishkuro approved these changes Dec 16, 2017

View reviewed changes

Check for null when processing traceID

6c6a82c

Signed-off-by: Joe Farro <joef@uber.com>

tiffon merged commit 6e5fa22 into master Dec 16, 2017

yurishkuro deleted the issue-128-endless-trace-http-reqs branch January 29, 2020 15:11

vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021

Merge pull request jaegertracing#136 from jaegertracing/issue-128-end…

6ffcdb4

…less-trace-http-reqs Fix endless trace HTTP requests Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix endless trace HTTP requests #136

Fix endless trace HTTP requests #136

tiffon commented Dec 16, 2017

codecov bot commented Dec 16, 2017 •

edited

Loading

yurishkuro Dec 16, 2017

tiffon Dec 16, 2017

Fix endless trace HTTP requests #136

Fix endless trace HTTP requests #136

Conversation

tiffon commented Dec 16, 2017

codecov bot commented Dec 16, 2017 • edited Loading

Codecov Report

yurishkuro Dec 16, 2017

Choose a reason for hiding this comment

tiffon Dec 16, 2017

Choose a reason for hiding this comment

codecov bot commented Dec 16, 2017 •

edited

Loading