Skip to content
This repository has been archived by the owner on Jul 11, 2022. It is now read-only.

Add package prefix to imports in generated code #313

Merged
merged 2 commits into from
Jul 14, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ shell:

# Generate jaeger thrifts
THRIFT_GEN_DIR=jaeger_client/thrift_gen
THRIFT_PACKAGE_PREFIX=jaeger_client.thrift_gen
THRIFT_VER=0.9.3
THRIFT_IMG=thrift:$(THRIFT_VER)
THRIFT_PY_ARGS=new_style,tornado
Expand All @@ -100,7 +101,7 @@ thrift: idl-submodule thrift-image
set -e; \
for f in $$(find ${THRIFT_GEN_DIR} -iname '*.py'); do \
echo fixing $$f; \
awk -f thrift-gen-fix.awk $$f > tmp; \
awk -f thrift-gen-fix.awk package_prefix=${THRIFT_PACKAGE_PREFIX} $$f > tmp; \
mv tmp $$f; \
done

Expand Down
7 changes: 0 additions & 7 deletions jaeger_client/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,6 @@

from __future__ import absolute_import

import sys

# This is because thrift for python doesn't have 'package_prefix'.
# The thrift compiled libraries refer to each other relative to their subdir.
import jaeger_client.thrift_gen as modpath
sys.path.append(modpath.__path__[0])

__version__ = '4.5.1.dev0'

from .tracer import Tracer # noqa
Expand Down
8 changes: 4 additions & 4 deletions jaeger_client/thrift_gen/agent/Agent.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions jaeger_client/thrift_gen/agent/ttypes.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions thrift-gen-fix.awk
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,8 @@ BEGIN {six=0}
{
gsub(/from ttype/, "from .ttype", $0);
gsub(/self.__dict__.iteritems\(\)/, "six.iteritems(self.__dict__)", $0);
if (package_prefix) {
$0 = gensub(/[[:alnum:]_]+\.ttypes/, package_prefix ".\\0", "g", $0);
}
print
}