This repository has been archived by the owner on Jul 11, 2022. It is now read-only.
Add package prefix to imports in generated code #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Packages generated with thrift refers to each other as if they are top level packages. This prevents imports from working when generated packages are placed inside some other package. Currently jaeger_client relies on hacking sys.path, but this doesn't work properly if the library is packed inside an application built using PyInstaller. Another way to get imports to work is to rewrite them after generation. This can be done easily since the build process already involves an awk script that performs a couple of replacements. Signed-off-by: Andrey Nikitin <ethframe@gmail.com>
Signed-off-by: Andrey Nikitin <ethframe@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #313 +/- ##
==========================================
+ Coverage 95.33% 95.42% +0.08%
==========================================
Files 23 25 +2
Lines 1931 1967 +36
Branches 272 272
==========================================
+ Hits 1841 1877 +36
Misses 56 56
Partials 34 34
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
thrift-gen-fix.awkappends package prefix to all references to*.ttypeswhen variablepackage_prefixis set.