Fixes isaaclab scripts to deal with Isaac Sim pip installation
#631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayankm96
changed the title
isaaclab scripts to deal with Isaac Sim pip installation
kellyguo11
reviewed
Jul 4, 2024
4 tasks
|
@kellyguo11 could you try again? Feel free to modify the branch/MR directly with the fixes needed for Windows |
Signed-off-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
This was referenced Jul 4, 2024
|
Pushed a few minor fixes, working for me on windows now |
|
I had to remove the default vscode setting up from the install script as it calls |
kellyguo11
reviewed
Jul 5, 2024
kellyguo11
approved these changes
Jul 5, 2024
6 tasks
Mayankm96
added a commit
that referenced
this pull request
Jul 5, 2024
# Description Realized that #631 did not deal properly with the case when not in a conda or docker. This MR re-writes the logic to hopefully make the operation safe. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
mohanksriram
pushed a commit
to mohanksriram/IsaacLab
that referenced
this pull request
Jul 12, 2024
…ac-sim#631) # Description Earlier the script hard-coded with path to Isaac Sim installation as the sym-linked directory "_isaac_sim". However, when doing PIP installation, this workflow doesn't hold. The MR modifies the scripts `isaaclab.sh` and `isaaclab.bat` to now check for PIP package installation and get paths from there if they exist. Fixes isaac-sim#516, isaac-sim#629 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com> Co-authored-by: Kelly Guo <kellyg@nvidia.com>
mohanksriram
pushed a commit
to mohanksriram/IsaacLab
that referenced
this pull request
Jul 12, 2024
) # Description Realized that isaac-sim#631 did not deal properly with the case when not in a conda or docker. This MR re-writes the logic to hopefully make the operation safe. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
fatimaanes
pushed a commit
to fatimaanes/omniperf
that referenced
this pull request
Aug 8, 2024
…ac-sim#631) # Description Earlier the script hard-coded with path to Isaac Sim installation as the sym-linked directory "_isaac_sim". However, when doing PIP installation, this workflow doesn't hold. The MR modifies the scripts `isaaclab.sh` and `isaaclab.bat` to now check for PIP package installation and get paths from there if they exist. Fixes isaac-sim#516, isaac-sim#629 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com> Co-authored-by: Kelly Guo <kellyg@nvidia.com>
fatimaanes
pushed a commit
to fatimaanes/omniperf
that referenced
this pull request
Aug 8, 2024
) # Description Realized that isaac-sim#631 did not deal properly with the case when not in a conda or docker. This MR re-writes the logic to hopefully make the operation safe. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Earlier the script hard-coded with path to Isaac Sim installation as the sym-linked directory "_isaac_sim". However, when doing PIP installation, this workflow doesn't hold. The MR modifies the scripts
isaaclab.shandisaaclab.batto now check for PIP package installation and get paths from there if they exist.Fixes #516, #629
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there