This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
fix: replace node Buffers with Uint8Arrays #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relaxes checks on `.Data` to allow for `Uint8Array`s in place of node `Buffer`s. BREAKING CHANGES: - `dagNode.Data` can now be a `Uint8Array`
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
==========================================
+ Coverage 97.54% 97.57% +0.02%
==========================================
Files 16 16
Lines 204 206 +2
==========================================
+ Hits 199 201 +2
Misses 5 5
Continue to review full report at Codecov.
|
vmx
reviewed
Jul 30, 2020
There was a problem hiding this comment.
Wow @achingbrain, you are moving fast (this is sooo good). I'll approve ones deps are ready.
2 tasks
4 tasks
Remove repo, block service and other unecessary deps.
vmx
approved these changes
Aug 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relaxes checks on
.Datato allow forUint8Arrays in place ofnode
Buffers.Depends on:
BREAKING CHANGES:
dagNode.Datais now aUint8Arrayutil.serializereturns aUint8Arrayutil.cidreturnsCIDs with a breaking API change - see fix: replace node buffers with uint8arrays multiformats/js-cid#117 for changes