dag-pb implementation of new interface?

[carsonfarmer]

It seems like this is sufficient to make it compatible (works in my tests locally). Is there a more "official" package already available (for compatibility reasons)?

const multiformats = require("multiformats/basics.js");
const { Buffer } = require("buffer");
const { util: { serialize, deserialize } } = require("ipld-dag-pb");
const dagpb = {
  encode: serialize,
  decode: buffer => deserialize(Buffer.from(buffer)),
  code: 0x70,
  name: "dag-pb",
};
multiformats.multicodec.add(dagpb);

[carsonfarmer]

Note I updated the above to include the Buffer.from wrapping, which was causing errors in some cases where the Block API returns a Uint8Array (because ipld-dag-pb has a check for isBuffer).

[achingbrain]

ipld-dag-pb is having buffers removed so hopefully that won't be necessary shortly: ipld/js-ipld-dag-pb#187

[carsonfarmer]

Cool! Would it make sense to just add the above (once your PR lands and the CID dep is updated) as a new/additional export from the js-ipld-dag-pb library and call it a day?

[mikeal]

if we get the other changes in to cids for the upcoming release we should be able to produce a library that easily works on both. if not, we can migrate this to the new interface and expose a js-ipld-interface compatible endpoint using the legacy function of js-multiformats.

[carsonfarmer]

What is the status on this work... is the legacy approach the best one here?

[rvagg]

https://github.com/ipld/js-dag-pb, solid and strict and has a matching Go friend now https://github.com/ipld/go-codec-dagpb