This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
Fix flaky tests in message queue #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Suggest merging #495 before reviewing this PR, as this PR appears to include those changes |
mock time in message queue to fix tests
Stebalien
force-pushed
the
fix/message-queue-tests
branch
from
85f4d84
to
9ccb51c
Compare
Stebalien
approved these changes
Jun 24, 2021
|
Failing tests are unrelated. |
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
Fix flaky tests in message queue This commit was moved from ipfs/go-bitswap@eac35a4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Fix all the flaky tests of the message queue
Implementation
Once again, errors come down to timing, and I'm fixing by mocking time in flaky tests
In this case, I didn't actually go and replace all the tests, as this would be a big endeavor
part of ipfs/boxo#86