This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
Fix flaky DontHaveTimeoutManger tests #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Part of ipfs/boxo#86 |
dirkmc
reviewed
Jun 4, 2021
| } else { | ||
| dhtm.checkForTimeoutsTimer.Stop() | ||
| dhtm.checkForTimeoutsTimer.Reset(until) | ||
| } | ||
| } | ||
|
|
||
| func (dhtm *dontHaveTimeoutMgr) consumeTimeouts() { | ||
| for { |
There was a problem hiding this comment.
I don't think this should be a for loop, because checkForTimeouts() is a recursive call
There was a problem hiding this comment.
note this will only get called once cause then checkForTimeoutsTimer will not be null.
There was a problem hiding this comment.
I think that the for loop will continue looping forever though - so I'm suggesting that we only have the select (without putting it inside a for loop)
| checkForTimeoutsTimer *time.Timer | ||
| checkForTimeoutsTimer *clock.Timer | ||
| // used for testing -- signal when a scheduled timeout check has happened | ||
| signal chan struct{} |
There was a problem hiding this comment.
nit: suggest renaming signal to something like timeoutChecked
hannahhoward
force-pushed
the
fix/fix-dont-have-manager-timeouts
branch
from
ee7f583
to
f60e47c
Compare
count message received before callback so that the count is always accurate at the time of counting
The TestSessionWithPeers test was most commonly failing cause of a don't have timeout, which triggered simulated don't have message for all CIDs on the peer with content, which triggered a re-broadcast, causing peers with no content to receive additional wants
s/SetSendDontHavesOnTimeout/SetSimulateDontHavesOnTimeout
convery DontHaveTimeoutMgr to use clock interface, use mocks in tests to make tests predictable and fast
Stebalien
force-pushed
the
fix/fix-dont-have-manager-timeouts
branch
from
f60e47c
to
38aae7e
Compare
|
These tests appear to be passing now. |
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
…nager-timeouts Fix flaky DontHaveTimeoutManger tests This commit was moved from ipfs/go-bitswap@bfac454
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Fix flaky tests for the DontHaveTimeoutManger
Implementation
Replace clock with a mock, so that we are able to mock out time in tests, modify tests to use mock time and be more predictable.
Also avoid AfterFunc cause of potential problems with channel consumption.