Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Only import pdftotext if installed (Fixes #1419) #1545

Merged
merged 1 commit into from
Jan 26, 2022
Merged

fix: Only import pdftotext if installed (Fixes #1419) #1545

merged 1 commit into from
Jan 26, 2022

Conversation

anthonyharrison
Copy link
Contributor

No description provided.

@anthonyharrison anthonyharrison changed the title [bug] Only import pdftotext if installed (Fixes #1419) bug: Only import pdftotext if installed (Fixes #1419) Jan 25, 2022
@anthonyharrison anthonyharrison changed the title bug: Only import pdftotext if installed (Fixes #1419) fix: Only import pdftotext if installed (Fixes #1419) Jan 25, 2022
terriko
terriko approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@terriko terriko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually kind of surprised flake8 doesn't hate this, but it does do the trick.

(and yes, I ran flake8 on it locally -- I know the CI was broken when this ran in Actions)

@terriko terriko merged commit 637bf64 into intel:main Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terriko terriko terriko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthonyharrison @terriko