Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let tests fail more gracefully if pdftotext not installed? #1419

Closed
terriko opened this issue Oct 26, 2021 · 1 comment
Closed

Let tests fail more gracefully if pdftotext not installed? #1419

terriko opened this issue Oct 26, 2021 · 1 comment

Comments

@terriko
Copy link
Contributor

terriko commented Oct 26, 2021

Currently tests fail if pdftotext is not installed, at the import stage. That's actually kind of fine, but it might be nice to print out a message explaining to a new developer what package(s) are missing.

Also, note for docs so I don't forget: the poppler dev library on fedora is called poppler-cpp-devel
@anthonyharrison
Copy link
Contributor

Pull request #1485 only did half the job! import pdftotext was still included in the file.

anthonyharrison added a commit to anthonyharrison/cve-bin-tool that referenced this issue Jan 24, 2022
@anthonyharrison
[bug] Only import pdftotext if installed (Fixes intel#1419)
60c793a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@terriko @anthonyharrison