New checker: gnome librsvg #1533
Conversation
|
I didn't see #1530 was already open, I can close this PR if needed CC: @terriko @BreadGenie |
There was a problem hiding this comment.
LGTM!
Tried it out with an apk file too and it works just fine.
@yashugarg you can discuss with the PR author on who would be submitting the PR. It seems like their PR is not complete yet.
|
|
||
|
|
||
| class LibrsvgChecker(Checker): | ||
| CONTAINS_PATTERNS = [] |
There was a problem hiding this comment.
You can add some unique patterns found in the executable here
There was a problem hiding this comment.
Hey @BreadGenie,
I did try to put Contains_Patterns, but neither the helper_script, nor the "strings" command gives any useable patterns.
There was a problem hiding this comment.
That's fine. BTW you might want to merge main or rebase to pass all the tests
There was a problem hiding this comment.
The tests work now!
|
Trying out the new rebase branch option, so CI is re-running now. |
Codecov Report
@@ Coverage Diff @@
## main #1533 +/- ##
==========================================
+ Coverage 80.36% 82.50% +2.14%
==========================================
Files 281 283 +2
Lines 5581 5597 +16
Branches 913 917 +4
==========================================
+ Hits 4485 4618 +133
+ Misses 897 784 -113
+ Partials 199 195 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
fixes #1494