Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checker librsvg #1530

Closed
wants to merge 4 commits into from
Closed

Add checker librsvg #1530

wants to merge 4 commits into from

Conversation

naomiceron
Copy link

This draft will solve #1494
I've been having problems making the test pass, but I will leave this draft PR in case it can help anybody.
If you have any notes, please let me know.

@terriko
Copy link
Contributor

terriko commented Jan 14, 2022

It looks like you'll need to rebase due to the big changes that have happened in the readme and manual docs. If the git conflicts look too complicated, you can grab the current README.md and doc/MANUAL.md from origin and re-apply the format_checkers changes.

Usually before I do something like this I save a copy of what I had into a tmp directory, just in case so the whole thing would look something like this:

Save a copy of those two files that we're going to revert:

mkdir ~/tmp
cp README.md ~/tmp/
cp doc/MANUAL.md ~/tmp/

Revert those two files:

git checkout -f README.md
git checkout -f doc/MANUAL.md

Rebase the whole tree:

git pull --rebase origin master

Then re-run format checkers:

python cve_bin_tool/format_checkers.py

@naomiceron
Copy link
Author

Thank you! it looks like it didn't bring me the files correctly, so I will look into it.

@terriko
Copy link
Contributor

terriko commented Jan 21, 2022

Ah, git checkout -f may be getting the copy of the file that lives in this PR. You'll want the one from main/origin. A quick google search says the commands you probably want are as follows:

git fetch origin/main
git checkout origin/main -- README.md
git checkout origin/main -- doc/MANUAL.md

@terriko
Copy link
Contributor

terriko commented Mar 10, 2022

We've got another librsvg checker merged so I'm going to close this, but do feel free to add your tests in a separate PR if you want -- they're different than the ones we merged.

@terriko terriko closed this Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants