Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow extractraction on all files to fail #1285

Merged
merged 11 commits into from
Aug 2, 2021
Merged

fix: allow extractraction on all files to fail #1285

merged 11 commits into from
Aug 2, 2021

Commits on Jul 29, 2021

  1. * fix: allow extracts on zip files to fail 

    Changes in intel#1181 to check return codes made it so failed extractions
caused cve-bin-tool to halt rather than log an error. This was
particularly a problem for .exe files, which we try to extract as
zipfiles in case they are self-extracting exectables.

Signed-off-by: Terri Oda <terri.oda@intel.com>
    @terriko
    terriko committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    2603940 View commit details
    Browse the repository at this point in the history

  2. fix: typo

    @terriko
    terriko committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    d124d25 View commit details
    Browse the repository at this point in the history

  3. test: extraction test with invalid zipfile .exe 

    This test is expected to fail currently and will need to pass before
this PR is ready to merge.

Signed-off-by: Terri Oda <terri.oda@intel.com>
    @terriko
    terriko committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    3ba8f26 View commit details
    Browse the repository at this point in the history

  4. test: add empty file

    @terriko
    terriko committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    12e96c5 View commit details
    Browse the repository at this point in the history

  5. fix: update logging, add zip+exe to test

    @terriko
    terriko committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    a3c6ac1 View commit details
    Browse the repository at this point in the history

  6. Black

    @terriko
    terriko committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    89cc4ed View commit details
    Browse the repository at this point in the history

  7. test: add cli test for log messages 

    Signed-off-by: Terri Oda <terri.oda@intel.com>
    @terriko
    terriko committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    99f1922 View commit details
    Browse the repository at this point in the history

  8. fix: allow all commands to fail and pass through

    @terriko
    terriko committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    f852177 View commit details
    Browse the repository at this point in the history

  9. test: update aio_run_command options in test

    @terriko
    terriko committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    86d3253 View commit details
    Browse the repository at this point in the history

  10. fix brackets

    @terriko
    terriko committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    619f0c6 View commit details
    Browse the repository at this point in the history

  11. Add empty zip file

    @terriko
    terriko committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    ad2e958 View commit details
    Browse the repository at this point in the history