async utils: aio_run_command(): check returncode #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1181 +/- ##
==========================================
- Coverage 79.81% 77.47% -2.34%
==========================================
Files 216 217 +1
Lines 4141 4169 +28
Branches 515 517 +2
==========================================
- Hits 3305 3230 -75
- Misses 705 798 +93
- Partials 131 141 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
BreadGenie
reviewed
Jun 17, 2021
terriko
requested changes
Jun 24, 2021
pdxjohnny
force-pushed
the
async_utils_aio_run_command_check_return_code
branch
from
5a8ea14
to
b9bf983
Compare
Raise subprocess.CalledProcessError if subprocess fails with a non-zero return code. Fixes: intel#1177 Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
terriko
approved these changes
Jun 30, 2021
terriko
added a commit
to terriko/cve-bin-tool
that referenced
this pull request
Jul 28, 2021
Changes in intel#1181 to check return codes made it so failed extractions caused cve-bin-tool to halt rather than log an error. This was particularly a problem for .exe files, which we try to extract as zipfiles in case they are self-extracting exectables. Signed-off-by: Terri Oda <terri.oda@intel.com>
terriko
added a commit
to terriko/cve-bin-tool
that referenced
this pull request
Jul 28, 2021
Changes in intel#1181 to check return codes made it so failed extractions caused cve-bin-tool to halt rather than log an error. This was particularly a problem for .exe files, which we try to extract as zipfiles in case they are self-extracting exectables. Signed-off-by: Terri Oda <terri.oda@intel.com>
terriko
added a commit
to terriko/cve-bin-tool
that referenced
this pull request
Jul 29, 2021
Changes in intel#1181 to check return codes made it so failed extractions caused cve-bin-tool to halt rather than log an error. This was particularly a problem for .exe files, which we try to extract as zipfiles in case they are self-extracting exectables. Signed-off-by: Terri Oda <terri.oda@intel.com>
terriko
added a commit
that referenced
this pull request
Aug 2, 2021
* fixes #1281 * Related to #1181 Changes in #1181 to check return codes made it so that cve-bin-tool failed if any file did not extract correctly. This changes the default so that failures during extraction are logged but do not halt the scan. Error messages are not logged when the file extension is .exe because users found those confusing (cve-bin-tool tries to unzip all .exe files in case they are self-extracting zipfiles, but many are not) Signed-off-by: Terri Oda <terri.oda@intel.com>
terriko
added a commit
that referenced
this pull request
Aug 4, 2021
* fixes #1281 * Related to #1181 Changes in #1181 to check return codes made it so that cve-bin-tool failed if any file did not extract correctly. This changes the default so that failures during extraction are logged but do not halt the scan. Error messages are not logged when the file extension is .exe because users found those confusing (cve-bin-tool tries to unzip all .exe files in case they are self-extracting zipfiles, but many are not) Signed-off-by: Terri Oda <terri.oda@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.