Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added HTML report test #1129

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Added HTML report test #1129

merged 1 commit into from
Jun 15, 2021

Conversation

jerinjtitus
Copy link
Contributor

@jerinjtitus jerinjtitus commented Apr 4, 2021

Signed-off-by: Jerin J Titus 72017981+jerinjtitus@users.noreply.github.com

Based on #1058

The test generates a html output (result) and asserts it against a saved sample report.
Since html reports contain dynamic data and dates, it required some manipulations. I replaced the date with "{{date}}" and all the dynamic div IDs with their repective line numbers, in both the result and sample report.

Signed-off-by: Jerin J Titus <72017981+jerinjtitus@users.noreply.github.com>
@codecov-io
Copy link

Codecov Report

Merging #1129 (9bb3ceb) into main (9edf66d) will increase coverage by 2.63%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1129      +/-   ##
==========================================
+ Coverage   86.67%   89.31%   +2.63%     
==========================================
  Files         181      183       +2     
  Lines        3016     3059      +43     
  Branches      333      337       +4     
==========================================
+ Hits         2614     2732     +118     
+ Misses        320      243      -77     
- Partials       82       84       +2     
Flag Coverage Δ
longtests 89.31% <100.00%> (+2.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_output_engine.py 98.27% <100.00%> (+0.54%) ⬆️
test/utils.py 97.14% <0.00%> (ø)
cve_bin_tool/version.py 70.00% <0.00%> (ø)
cve_bin_tool/checkers/zlib.py 100.00% <0.00%> (ø)
cve_bin_tool/checkers/glibc.py 100.00% <0.00%> (ø)
cve_bin_tool/checkers/nessus.py 100.00% <0.00%> (ø)
cve_bin_tool/checkers/systemd.py 100.00% <0.00%> (ø)
cve_bin_tool/checkers/__init__.py 95.55% <0.00%> (ø)
cve_bin_tool/checkers/polarssl_fedora.py 100.00% <0.00%> (ø)
cve_bin_tool/checkers/p7zip.py 100.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9edf66d...9bb3ceb. Read the comment docs.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. Sorry it took so long to merge!

@terriko terriko merged commit 585e578 into intel:main Jun 15, 2021
@BreadGenie BreadGenie mentioned this pull request Jun 16, 2021
@terriko terriko mentioned this pull request Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants