Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tests #1175

Merged
merged 2 commits into from
Jun 16, 2021
Merged

Fix Tests #1175

merged 2 commits into from
Jun 16, 2021

Conversation

BreadGenie
Copy link
Contributor

@BreadGenie BreadGenie commented Jun 16, 2021

There was a mismatch in the way datetime was imported in c6d71c6 and 585e578 in the test_output_engine.py file leading to failing tests

@BreadGenie
Copy link
Contributor Author

I have noticed long test failing in c6d71c6 but the NVD server seems down at the moment to check properly

@BreadGenie
Copy link
Contributor Author

BreadGenie commented Jun 16, 2021

Seems like c6d71c6 doesn't work when we provide -u never and tool crashes with a AttributeError: 'CVEDB' object has no attribute 'time_of_last_update'

The time_of_last_update attribute is now defined when -u never parameter is given
@codecov-commenter
Copy link

Codecov Report

Merging #1175 (b37b668) into main (10cb6fd) will increase coverage by 0.21%.
The diff coverage is 60.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1175      +/-   ##
==========================================
+ Coverage   83.96%   84.18%   +0.21%     
==========================================
  Files         186      199      +13     
  Lines        3212     3528     +316     
  Branches      351      412      +61     
==========================================
+ Hits         2697     2970     +273     
- Misses        432      455      +23     
- Partials       83      103      +20     
Flag Coverage Δ
longtests 84.18% <60.86%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/checkers/avahi.py 100.00% <ø> (ø)
cve_bin_tool/checkers/bash.py 100.00% <ø> (ø)
cve_bin_tool/checkers/bind.py 100.00% <ø> (ø)
cve_bin_tool/checkers/binutils.py 100.00% <ø> (ø)
cve_bin_tool/checkers/busybox.py 100.00% <ø> (ø)
cve_bin_tool/checkers/bzip2.py 100.00% <ø> (ø)
cve_bin_tool/checkers/cups.py 100.00% <ø> (ø)
cve_bin_tool/checkers/curl.py 100.00% <ø> (ø)
cve_bin_tool/checkers/dnsmasq.py 100.00% <ø> (ø)
cve_bin_tool/checkers/dovecot.py 100.00% <ø> (ø)
... and 118 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cfc167...b37b668. Read the comment docs.

@terriko terriko merged commit efac544 into intel:main Jun 16, 2021
@BreadGenie BreadGenie deleted the test-fix branch June 18, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants