Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aggregator metric drop #5632

Merged
merged 2 commits into from
Mar 27, 2019
Merged

Fix aggregator metric drop #5632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53df134
Update docker-compose.yml
ushuz Mar 26, 2019
7a2a866
Add missing metric.Drop() call in runAggregators()
ushuz Mar 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions agent/agent.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,8 @@ func (a *Agent) runAggregators(

if !dropOriginal {
dst <- metric
} else {
metric.Drop()
}
}
cancel()
Expand Down
4 changes: 2 additions & 2 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ services:
- KAFKA_ADVERTISED_HOST_NAME=localhost
- KAFKA_ADVERTISED_PORT=9092
- KAFKA_ZOOKEEPER_CONNECT=zookeeper:2181
- KAFKA_CREATE_TOPICS="test:1:1"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This no longer works, it yields:

...
kafka_1          | creating topics: "test:1:1"
kafka_1          | Missing required argument "[partitions]"
kafka_1          | Option                                   Description
kafka_1          | ------                                   -----------
kafka_1          | --alter                                  Alter the number of partitions,
...

- KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR=1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single node kafka cluster is not writable without this.

- JAVA_OPTS="-Xms256m -Xmx256m"
ports:
- "9092:9092"
Expand All @@ -38,7 +38,7 @@ services:
- "3306:3306"
memcached:
image: memcached
ports:
ports:
- "11211:11211"
pgbouncer:
image: mbed/pgbouncer
Expand Down