Fix aggregator metric drop #5632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ushuz
commented
Mar 26, 2019
| @@ -17,7 +17,7 @@ services: | |||
| - KAFKA_ADVERTISED_HOST_NAME=localhost | |||
| - KAFKA_ADVERTISED_PORT=9092 | |||
| - KAFKA_ZOOKEEPER_CONNECT=zookeeper:2181 | |||
| - KAFKA_CREATE_TOPICS="test:1:1" | |||
| - KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR=1 | |||
There was a problem hiding this comment.
Single node kafka cluster is not writable without this.
| @@ -17,7 +17,7 @@ services: | |||
| - KAFKA_ADVERTISED_HOST_NAME=localhost | |||
| - KAFKA_ADVERTISED_PORT=9092 | |||
| - KAFKA_ZOOKEEPER_CONNECT=zookeeper:2181 | |||
| - KAFKA_CREATE_TOPICS="test:1:1" | |||
There was a problem hiding this comment.
This no longer works, it yields:
...
kafka_1 | creating topics: "test:1:1"
kafka_1 | Missing required argument "[partitions]"
kafka_1 | Option Description
kafka_1 | ------ -----------
kafka_1 | --alter Alter the number of partitions,
...
danielnelson
pushed a commit
that referenced
this pull request
Mar 27, 2019
(cherry picked from commit 5e6374c)
dupondje
pushed a commit
to dupondje/telegraf
that referenced
this pull request
Apr 22, 2019
hwaastad
pushed a commit
to hwaastad/telegraf
that referenced
this pull request
Jun 13, 2019
bitcharmer
pushed a commit
to bitcharmer/telegraf
that referenced
this pull request
Oct 18, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aggregators'
drop_original = truedoesn't work well with*_consumerinputs'max_undelivered_messages. (mentioned by me at #5595 (comment))*_consumerinputs are usingAddTrackingMetricGroupto find out whether metrics get delivered (eitherAcceptorDrop,Rejectwon't count). However, whendrop_original = true, metrics are dropped without callingmetric.Drop(). As a result, inputs lost track of metrics, consider dropped metrics undelivered, andmax_undelivered_messagesis reached rather quickly. Eventually,*_consumerinputs stop consuming new messages.Required for all PRs: