Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add messages_delivered_get to rabbitmq_overview #3596

Merged
merged 2 commits into from
Dec 19, 2017
Merged

Add messages_delivered_get to rabbitmq_overview #3596

merged 2 commits into from
Dec 19, 2017

Conversation

kerams
Copy link
Contributor

@kerams kerams commented Dec 16, 2017

As discussed in #3586. messages_delivered_get represents the grand total of messages delivered since the node's startup.

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.


```
SELECT NON_NEGATIVE_DIFFERENCE(LAST("messages_published")) AS messages_published_rate
FROM rabbitmq_overview WHERE time > now() - 10m GROUP BY time(1m)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might recommend non_negative_derivative(..., 1m) instead of difference(). That way the query always gives you the 1m rate, regardless of the group by interval. Both methods are perfectly valid, just the derivative tends to be more useful in graphing as your group by interval changes based on the time range.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright.

@danielnelson danielnelson added this to the 1.6.0 milestone Dec 19, 2017
@danielnelson danielnelson added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Dec 19, 2017
@danielnelson danielnelson merged commit 4964521 into influxdata:master Dec 19, 2017
@kerams kerams deleted the message-delivered-get branch December 19, 2017 07:03
@kerams kerams mentioned this pull request Jan 3, 2018
3 tasks
aromeyer pushed a commit to aromeyer/telegraf that referenced this pull request May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants