Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add total message rates for RabbitMQ input plugin #3586

Closed
wants to merge 2 commits into from
Closed

Add total message rates for RabbitMQ input plugin #3586

wants to merge 2 commits into from

Conversation

kerams
Copy link
Contributor

@kerams kerams commented Dec 14, 2017

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@danielnelson
Copy link
Contributor

Can the rate values be calculated from the message counts at query time? If so this will be more flexible since you will be able to calculate over any unit of time such as messages/minute, as well as using less storage on the database.

We can definitely add messages_delivered_get.

@danielnelson danielnelson added area/rabbitmq feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Dec 14, 2017
@kerams
Copy link
Contributor Author

kerams commented Dec 15, 2017

No, I don't think so. The counts increase with every message and as far as I can tell they never reset (they certainly do not represent message counts for the sample period, which is 5s by default).

EDIT: I can now confirm that those are the total counts since the node's startup, which makes them far less interesting than the current rates.

@danielnelson
Copy link
Contributor

Maybe you can use this query:

select non_negative_difference(last("messages_published")) as messages_published_rate from rabbitmq_overview where time > now() - 10m group by time(1m)

@kerams
Copy link
Contributor Author

kerams commented Dec 15, 2017

Oh, yeah, that didn't occur to me. However, I think it would be nice to have those rates as they are already recorded for every queue :). Your call.

@danielnelson
Copy link
Contributor

I'd rather not have them, because they can't be aggregated and they are duplicate information. However, we should add the messages_delivered_get and we could add some documentation about this query.

@kerams
Copy link
Contributor Author

kerams commented Dec 16, 2017

Alright, I'll open a new PR for that

@kerams kerams closed this Dec 16, 2017
@kerams kerams deleted the message-rates branch December 16, 2017 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rabbitmq feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants