Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VSphere input plugin #2682

Closed
wants to merge 542 commits into from
Closed

Conversation

mlabouardy
Copy link
Contributor

@mlabouardy mlabouardy commented Apr 18, 2017

Required for all PRs:

  • CHANGELOG.md updated (we recommend not updating this until the PR has been approved by a maintainer)
  • Sign CLA (if not already signed)
  • README.md updated (if adding a new plugin)

@mlabouardy mlabouardy changed the title add vsphere input plugin Add vsphere input plugin Apr 18, 2017
@mlabouardy mlabouardy changed the title Add vsphere input plugin Add VSphere input plugin Apr 19, 2017
@mkuzmin
Copy link

mkuzmin commented Jul 23, 2017

This PR is a good start, but we need a bit more work to reach acceptable level of quality.

I also developed pretty the same plugin, but not going to publish alternate PR. Instead, I rebased my fixes on top of your code at https://github.com/mkuzmin/telegraf/commits/vsphere.
There was a sad story of unhealthy competition in vSphere plugins for Terraform and Packer, and I really don't want to repeat the same mistakes here. Let's join the forces, and develop the best solution together.

I'd suggest the next plan:

  1. You mark this PR as [WIP]
  2. You rebase the code to release-1.3 branch until we finish the work. I want to use this code in production ASAP, but it should not involve changes in Telegraf core.
    Squashing commits would be helpful.
  3. I will post my contributions as PRs to your repository. We discuss and agree on all the changes. I'd like to have contributor permissions, so after review I'm able to merge PRs by myself.
  4. We publish binary releases and involve people to test our code and provide early feedback.

@danielnelson
Copy link
Contributor

@mkuzmin @mlabouardy Have you made any progress on unifying your plugins?

@mlabouardy
Copy link
Contributor Author

@mkuzmin I rebased the code to https://github.com/mlabouardy/telegraf/tree/release-1.3

I added you as contributor

@mkuzmin
Copy link

mkuzmin commented Nov 8, 2017

Thank you. I will return to this PR soon.

@huyujie
Copy link

huyujie commented Nov 28, 2017

@mlabouardy @mkuzmin when I use this vsphere plugin,output:"default datacenter resolves to multiple instances, please specify"

@ideologysec
Copy link

@huyujie export GOVC_DATACENTER="Your Datacenter Name Here"

@danielnelson
Copy link
Contributor

Closing in favor of #4141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin new plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.