Added CloudWatch metric constraint validation #3183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Nickoloff <jeff@allingeek.com>
|
I've been running a build based on these changes in an environment where we always see the issue noted in #2523 for a few hours now and we've not encountered the problem. |
danielnelson
pushed a commit
that referenced
this pull request
Aug 29, 2017
(cherry picked from commit ac1fa05)
|
Thanks for the merge. |
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added CloudWatch metric constraint validation for float64 numbers. The constraints are detailed here: http://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/API_MetricDatum.html. Added relevant links in comments for those otherwise magic numbers.
Also added positive and negative tests for these boundaries.
This change should fix #2523
Signed-off-by: Jeff Nickoloff jeff@allingeek.com
Required for all PRs: