Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kubernetes): Only initialize RoundTripper once #1951

Merged
merged 1 commit into from
Oct 26, 2016

Conversation

jchauncey
Copy link

fixes #1933

@jchauncey
Copy link
Author

@sparrc Since the kubernetes plugin hadn't been released yet I didnt add this bug fix to the changelog. Do you still want me to do that?

@sparrc
Copy link
Contributor

sparrc commented Oct 25, 2016

that's alright, can you rebase your changes so the CircleCI tests pass? Have you tested that this fixes the issue?

@jchauncey
Copy link
Author

Yeah we tested that this fixes the issue. I'll rebase in just a bit.

On Oct 25, 2016 11:30 AM, "Cameron Sparr" notifications@github.com wrote:

that's alright, can you rebase your changes so the CircleCI tests pass?
Have you tested that this fixes the issue?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1951 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAaRGFNXGQ1Ocb7QvhQiCZPDzoTeD408ks5q3iCCgaJpZM4KgFNl
.

@jchauncey
Copy link
Author

We should probably open an issue to audit the other plugins that reach out over http and make sure they are following the same pattern.

@sparrc
Copy link
Contributor

sparrc commented Oct 26, 2016

thanks @jchauncey, I opened #1954

@sparrc sparrc merged commit b1a97e3 into influxdata:master Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kuberentes plugin leaking connections
2 participants