Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit plugin usage of http.Transport & http.RoundTripper #1954

Closed
sparrc opened this issue Oct 26, 2016 · 1 comment · Fixed by #2782
Closed

Audit plugin usage of http.Transport & http.RoundTripper #1954

sparrc opened this issue Oct 26, 2016 · 1 comment · Fixed by #2782
Assignees
@danielnelson
Milestone
1.3.1

Comments

@sparrc
Copy link
Contributor

sparrc commented Oct 26, 2016 •
edited
Loading

http.Transport & http.RoundTripper should only be instantiated once and re-used. Plugins that use this construct should be audited to verify that this is not being recreated on every call to Gather()

see #1951 & #1933
@sparrc sparrc added this to the 1.2.0 milestone Oct 26, 2016
@sparrc sparrc changed the title Audit usage of http.Transport & http.RoundTripper Audit plugin usage of http.Transport & http.RoundTripper Oct 26, 2016
@sparrc sparrc mentioned this issue Oct 26, 2016
Merged
@danielnelson danielnelson modified the milestones: 1.3.0, 1.2.0 Apr 12, 2017
@danielnelson
Copy link
Contributor

I found issues in the these inputs:

  • http_response
  • apache
  • prometheus

@danielnelson danielnelson modified the milestones: 1.4.0, 1.3.0 Apr 25, 2017
@danielnelson danielnelson mentioned this issue May 10, 2017
Merged
1 task
@danielnelson danielnelson modified the milestones: 1.3.1, 1.4.0 May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielnelson danielnelson

Labels
None yet
Projects
None yet
Milestone
1.3.1
Development

Successfully merging a pull request may close this issue.

Reuse transport in input plugins influxdata/telegraf
3 participants
@danielnelson @sparrc @121watts