Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(services): set default chain-id in client.toml (backport #4183) #4186

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 12, 2024

The default client.toml doesn't have chain-id specified, which requires a user to always use the --chain-id flag when using directly the binary instead of ignite (that does autodetection by querying the node status)


This is an automatic backport of pull request #4183 done by Mergify.

* feat(services): set default chain-id in client.toml

* changelog

(cherry picked from commit 27930b1)
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs type:services Service-related issues. labels Jun 12, 2024
@julienrbrt julienrbrt self-assigned this Jun 12, 2024
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix the conflicts tonight

@julienrbrt julienrbrt enabled auto-merge (squash) June 13, 2024 08:56
@julienrbrt julienrbrt merged commit a059acb into release/v28.x.y Jun 13, 2024
42 of 44 checks passed
@julienrbrt julienrbrt deleted the mergify/bp/release/v28.x.y/pr-4183 branch June 13, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ci CI/CD workflow and automated jobs. component:configs type:services Service-related issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants