Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(services): set default chain-id in client.toml #4183

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

julienrbrt
Copy link
Member

The default client.toml doesn't have chain-id specified, which requires a user to always use the --chain-id flag when using directly the binary instead of ignite (that does autodetection by querying the node status)

@julienrbrt julienrbrt added the backport/v28.x.y Backport to v28.x.y label Jun 7, 2024
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs type:services Service-related issues. labels Jun 7, 2024
Copy link
Collaborator

@Pantani Pantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PLEASE LGMT!!!!

@Pantani Pantani merged commit 27930b1 into main Jun 12, 2024
46 checks passed
@Pantani Pantani deleted the julien/init-client-toml-chain-id branch June 12, 2024 15:28
mergify bot pushed a commit that referenced this pull request Jun 12, 2024
* feat(services): set default chain-id in client.toml

* changelog

(cherry picked from commit 27930b1)
julienrbrt added a commit that referenced this pull request Jun 13, 2024
…4186)

* feat(services): set default chain-id in client.toml (#4183)

* feat(services): set default chain-id in client.toml

* changelog

(cherry picked from commit 27930b1)

* fix changelog

---------

Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v28.x.y Backport to v28.x.y component:ci CI/CD workflow and automated jobs. component:configs type:services Service-related issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants