#2256 Update Docker setup for Development and Test #2304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fails db setup when this is missing.
sbpipb
changed the title
julianguyen
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the Docker setup for development. This was tested on a WSL 2 and Ubuntu setup
More Details
Corresponding Issue
#2256
Screenshots
ran db:reset, db:setup, shows that it's working on rails console.
This was done on a WSL 2 setup for Windows Running Ubuntu Linux.
I was able to verify by logging in locally.
Reviewing this pull request? Check out our Code Review Practices guide if you haven't already!
Things to note!
I'm aware that the host, username and password lines on database config was removed for a reason, i'd like to check on why this was needed for tests to run correctly.. if someone can link me up with this issue, that would be great! *based on the CI pipeline results, all tests have passed.
i've updated the wiki installation documentation page