Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the grid validity with PSDM validation utils #462

Merged
merged 11 commits into from
Feb 21, 2023

Conversation

staudtMarius
Copy link
Member

Resolves #460

@staudtMarius staudtMarius added the enhancement New feature or request label Feb 17, 2023
@staudtMarius staudtMarius self-assigned this Feb 17, 2023
@sebastian-peter
Copy link
Member

!test

Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some hints that could improve the code

@staudtMarius staudtMarius marked this pull request as ready for review February 20, 2023 12:07
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just slightly adapted the log messages and let's go

@sebastian-peter sebastian-peter merged commit 2edae3b into dev Feb 21, 2023
@sebastian-peter sebastian-peter deleted the ms/#460-check-the-grid-for-validity branch February 21, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check the grid for validity with the PSDM validation utils
2 participants