Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the grid for validity with the PSDM validation utils #460

Closed
t-ober opened this issue Feb 16, 2023 · 1 comment · Fixed by #462
Closed

Check the grid for validity with the PSDM validation utils #460

t-ober opened this issue Feb 16, 2023 · 1 comment · Fixed by #462
Assignees
@staudtMarius
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
Version 3.0

Comments

@t-ober
Copy link
Contributor

t-ober commented Feb 16, 2023 •
edited
Loading

We should check the grid we use for the simulation with the ValidationUtils.check() of the PSDM, and at least issue a warning in case the validation fails. Running simulation with a misconfigured grid model can lead to errors that are hard to track.
@t-ober t-ober added enhancement New feature or request good first issue Good for newcomers labels Feb 16, 2023
@t-ober t-ober mentioned this issue Feb 16, 2023
Open
@sebastian-peter
Copy link
Member

I think this is important enough to get in the next release of SIMONA, which should happen shortly

@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Feb 17, 2023
@staudtMarius staudtMarius mentioned this issue Feb 17, 2023
Merged
staudtMarius added a commit that referenced this issue Feb 17, 2023
@staudtMarius
Merge branch 'dev' into ms/#460-check-the-grid-for-validity
7d71b19
staudtMarius added a commit that referenced this issue Feb 17, 2023
@staudtMarius
Merge remote-tracking branch 'origin/ms/#460-check-the-grid-for-valid…
cc70b15 
…ity' into ms/#460-check-the-grid-for-validity
staudtMarius added a commit that referenced this issue Feb 20, 2023
@staudtMarius
Merge branch 'dev' into ms/#460-check-the-grid-for-validity
27a11de
sebastian-peter added a commit that referenced this issue Feb 21, 2023
@sebastian-peter
Merge pull request #462 from ie3-institute/ms/#460-check-the-grid-for…
2edae3b 
…-validity

Check the grid validity with PSDM validation utils
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@staudtMarius staudtMarius

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging a pull request may close this issue.

Check the grid validity with PSDM validation utils ie3-institute/simona
3 participants
@sebastian-peter @t-ober @staudtMarius