-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix name and protocol changes within simonaAPI #385
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice ! Just a few minor things 🙂
val (tickInterval, lastEvs) = | ||
getTickIntervalAndLastEvs(currentTick, modelBaseStateData) | ||
getTickIntervalAndLastEvs(tick, modelBaseStateData) | ||
|
||
validateDepartures(lastEvs, requestedDepartingEvs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does last evs refer to the evs currently at the evcs upon request ? I think currentEvs
would be clearer. If you agree we should als adapt the method signature of getTickIntervalAndLastEvs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't agree to that since the EVs retrieved here stem from a tick in the past, thus lastEvs
. This is in contrast to the EVs that are determined for the current tick, namely the ones staying plus arrivals, thus currentEvs
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also makes sense if you look at the naming of currentTick
, which is the tick currently activated. A tick at which the agent was active before the current tick I would name lastTick
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the point (and was expecting that you will make it 😄 ) but I would understand it a bit differently.
Since we haven't dealt with arrivals and departures yet, the current evs are still the evs from last tick. Nevertheless I don't think we have to drag that on here.
src/main/scala/edu/ie3/simona/agent/participant/evcs/EvcsAgentFundamentals.scala
Outdated
Show resolved
Hide resolved
src/main/scala/edu/ie3/simona/agent/participant/evcs/EvcsAgentFundamentals.scala
Outdated
Show resolved
Hide resolved
src/main/scala/edu/ie3/simona/agent/participant/evcs/EvcsAgentFundamentals.scala
Show resolved
Hide resolved
src/main/scala/edu/ie3/simona/agent/participant/evcs/EvcsAgentFundamentals.scala
Show resolved
Hide resolved
src/main/scala/edu/ie3/simona/agent/participant/evcs/EvcsAgentFundamentals.scala
Show resolved
Hide resolved
src/main/scala/edu/ie3/simona/agent/participant/evcs/EvcsAgentFundamentals.scala
Show resolved
Hide resolved
Co-authored-by: t-ober <63147366+t-ober@users.noreply.github.com>
resolves #384
Mainly based on previous work of @sebastian-peter