Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix breaking SIMONA due to renamed messages and changed protocol in simonaAPI #384

Closed
danielfeismann opened this issue Oct 17, 2022 · 0 comments · Fixed by #385
Closed

Fix breaking SIMONA due to renamed messages and changed protocol in simonaAPI #384

danielfeismann opened this issue Oct 17, 2022 · 0 comments · Fixed by #385
Assignees
@danielfeismann
Labels
dependencies Pull requests that update a dependency file

Comments

@danielfeismann
Copy link
Member

danielfeismann commented Oct 17, 2022 •
edited
Loading

Since changing names and separating departures and arrivals in message protocol with simonaAPI#64 and simonaAPI#78 SIMONA breaks. This need to be fixed.
@danielfeismann danielfeismann added the dependencies Pull requests that update a dependency file label Oct 17, 2022
@danielfeismann danielfeismann self-assigned this Oct 17, 2022
@danielfeismann danielfeismann mentioned this issue Oct 17, 2022
Merged
@danielfeismann danielfeismann changed the title Fix breaking SIMONA due to renamed messages in simonaAPI Fix breaking SIMONA due to renamed messages and changed protocol in simonaAPI Oct 17, 2022
t-ober added a commit that referenced this issue Oct 19, 2022
@t-ober
Merge pull request #385 from ie3-institute/df/#384-fix-simonaAPI-brea…
460f293 
…king

Fix name and protocol changes within simonaAPI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielfeismann danielfeismann

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix name and protocol changes within simonaAPI ie3-institute/simona
1 participant
@danielfeismann