Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacement of end tick by current tick within the simulation scheduler #373

Merged
merged 18 commits into from
Jan 24, 2023
Merged

Replacement of end tick by current tick within the simulation scheduler #373

merged 18 commits into from
Jan 24, 2023

Conversation

vickybung1
Copy link
Contributor

Resolves #159

@sebastian-peter sebastian-peter added the bug Something isn't working label Oct 13, 2022
@vickybung1
Copy link
Contributor Author

What is the error about?

sebastian-peter
sebastian-peter requested changes Nov 9, 2022
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your changes, thanks for the work. I just have some minor questions and tips for simplifying the code. Let me know if I can help

src/main/scala/edu/ie3/simona/scheduler/SchedulerHelper.scala Outdated Show resolved Hide resolved
src/main/scala/edu/ie3/simona/scheduler/SchedulerHelper.scala Outdated Show resolved Hide resolved
src/main/scala/edu/ie3/simona/scheduler/SchedulerHelper.scala Outdated Show resolved Hide resolved
src/main/scala/edu/ie3/simona/scheduler/SchedulerHelper.scala Outdated Show resolved Hide resolved
sebastian-peter
sebastian-peter requested changes Jan 19, 2023
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one more tiny issue, I think then we're good to go!

src/main/scala/edu/ie3/simona/scheduler/SchedulerHelper.scala Outdated Show resolved Hide resolved
sebastian-peter
sebastian-peter approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@sebastian-peter sebastian-peter merged commit 0733082 into dev Jan 24, 2023
@sebastian-peter sebastian-peter deleted the vb/#159_current_tick branch January 24, 2023 15:27
@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-peter sebastian-peter sebastian-peter approved these changes

@t-ober t-ober Awaiting requested review from t-ober

@danielfeismann danielfeismann Awaiting requested review from danielfeismann

Assignees

@vickybung1 vickybung1

Labels
bug Something isn't working
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.

Use correct tick when simulation ends
3 participants
@vickybung1 @sebastian-peter @t-ober