Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct tick when simulation ends #159

Closed
sebastian-peter opened this issue Mar 1, 2022 · 3 comments · Fixed by #373
Closed

Use correct tick when simulation ends #159

sebastian-peter opened this issue Mar 1, 2022 · 3 comments · Fixed by #373
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@sebastian-peter
Copy link
Member

sebastian-peter commented Mar 1, 2022

When the simulation ends, the current tick instead of the endTick should be used. This makes a difference if the simulation ends prematurely.

Finally, add a test for this.

@sebastian-peter sebastian-peter added bug Something isn't working good first issue Good for newcomers labels Mar 1, 2022
@RishiKumarRay
Copy link

so we need to replace endTick with CurrentTick? or am i missing out something

@sebastian-peter
Copy link
Member Author

Yes, the current tick is stored in stateData.time.nowInTicks.

The problem here is the test though, as we do not have any tests for SimScheduler and failed simulations in this repository yet. This could be a little tricky.

@sebastian-peter
Copy link
Member Author

SimScheduler tests have been consolidated since #286, so this could be more doable now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants